RFR: 8296470: Refactor VMError::report STEP macro to improve readability [v2]

Axel Boldt-Christmas aboldtch at openjdk.org
Thu Nov 17 10:29:34 UTC 2022


> Refactor the STEP macro in VMError::report to improve readability.
> Right now the macro contains multiple statements on one line and the non-conventional control flow is even harder to understand.
> 
> This enhancement aims to do two things:
>  1. It splits the macro into multiple lines with indentations which makes the structure of the C++ code generated by the preprocessor clearer.
>   2. Separates the internal step logic from the decision logic which decides if a step should be taken with a STEP_IF(step_name_str, condition) macro
> 
> Testing: tier 1 + GHA

Axel Boldt-Christmas has updated the pull request incrementally with three additional commits since the last revision:

 - Follow HotSpot code style: no implicit boolean
 - Respect 100 character line
 - Revert extended test

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/11018/files
  - new: https://git.openjdk.org/jdk/pull/11018/files/944ce8d1..b483c21c

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=11018&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=11018&range=00-01

  Stats: 31 lines in 2 files changed: 7 ins; 10 del; 14 mod
  Patch: https://git.openjdk.org/jdk/pull/11018.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/11018/head:pull/11018

PR: https://git.openjdk.org/jdk/pull/11018


More information about the hotspot-dev mailing list