RFR: JDK-8296907: VMError: add optional callstacks, siginfo for secondary errors [v3]

[Thomas Stuefe]

On Thu, 17 Nov 2022 14:09:47 GMT, Axel Boldt-Christmas <aboldtch at openjdk.org> wrote:

>> It would work horizontally too, though, since it would disable call stack printing for the next secondary error.
>> 
>> I still think yours is a good idea. We can extend it to using a counter and only allow a small number (2-5) of secondary errors to get printed out with their call stacks. Because if we have more than, say, 5 recursive errors, chances are they all trip over the same thing anyway and more call stacks won't tell you anything new.
>> 
>> And then, if we limit the number of these things, maybe we can afford to leave this feature on by default in debug builds. That addresses the concern  @dholmes-ora voiced, about having to switch on the feature first.
>
>>  since it would disable call stack printing for the next secondary error.
> 
>  Would it? The example above would only disable reentering the if scope if we have a crash in `[...]`. If it is fine the flag is reset, and if we crash in `[...]` it will not enter the if scope and reset the flag. When it crash in a new secondary error it will once again enter the if scope and try to print the call stack. 
> 
> But I agree that there is always this taking it one step deeper of where you make things recoverable.

Right, you did reset it, I see now. Sorry, did not look close enough :)

-------------

PR: https://git.openjdk.org/jdk/pull/11118