RFR: JDK-8296796: Provide clean, platform-agnostic interface to C-heap trimming [v2]

Thomas Stuefe stuefe at openjdk.org
Fri Nov 18 14:08:20 UTC 2022


On Fri, 18 Nov 2022 12:54:34 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

> Looks good to me.

Thank you!

> I kinda like the OS interface. If the proliferation of lots of unimplemented methods in os/* is a concern, we could provide default impls in shared if !**GLIBC** as a middle-ground. WDYT?

I fear this would annoy people even more than platform defines. Ioi did use something with "HAVE_xxxx_xxxx" macros to provide default implementations for similar things, but I think in this case we are talking about so little code, its not worth the trouble.

-------------

PR: https://git.openjdk.org/jdk/pull/11089


More information about the hotspot-dev mailing list