RFR: JDK-8286666: JEP 429: Implementation of Scoped Values (Incubator) [v10]
Andrew Haley
aph at openjdk.org
Fri Nov 18 15:55:30 UTC 2022
On Thu, 17 Nov 2022 18:58:11 GMT, Andrew Haley <aph at openjdk.org> wrote:
>> src/hotspot/share/utilities/exceptions.cpp line 166:
>>
>>> 164: // Remove the ScopedValue cache in case we got a virtual machine
>>> 165: // Error while we were trying to manipulate ScopedValue bindings.
>>> 166: thread->set_scopedValueCache(NULL);
>>
>> I am see this pattern repeat quite often:
>>
>> thread->set_scopedValueCache(NULL);
>> oop threadObj = thread->vthread();
>> assert(threadOop != NULL, "must be"); // <--- sometimes
>> java_lang_Thread::clear_scopedValueBindings(threadObj);
>>
>> Encapsulate in a method on the `JavaThread` class?
>
> That sounds good.
Done.
-------------
PR: https://git.openjdk.org/jdk/pull/10952
More information about the hotspot-dev
mailing list