RFR: JDK-8286666: JEP 429: Implementation of Scoped Values (Incubator) [v15]

[Alan Bateman]

On Fri, 18 Nov 2022 17:19:24 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> JEP 429 implementation.
>
> Andrew Haley has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Reviewer feedback
>  - Reviewer feedback Javadoc fixes

src/java.base/share/classes/java/lang/Thread.java line 789:

> 787: 
> 788:         // special value to mean a new thread
> 789:         this.scopedValueBindings = NEW_THREAD_BINDINGS;

Can we change the comment on this one to be the same as the other constructor?

src/java.base/share/classes/java/lang/Thread.java line 1622:

> 1620:     // The VM recognizes this method as special, so any changes to the
> 1621:     // name or signature require corresponding changes in
> 1622:     // JVM_FindScopedValueBindings().

Minor nit but I'd prefer to keep things consistent with the existing code/style where we can. In this case, we can move the comment to move the annotations with the /* .. */ comments so it's the same as the other methods.

src/java.base/share/classes/java/lang/VirtualThread.java line 316:

> 314:         }
> 315:     }
> 316:     @Hidden

Missing line break.
Suggestion:


    @Hidden

-------------

PR: https://git.openjdk.org/jdk/pull/10952