RFR: 8297106: Remove the -Xcheck:jni local reference capacity checking [v3]

David Holmes dholmes at openjdk.org
Tue Nov 22 22:35:37 UTC 2022


On Tue, 22 Nov 2022 22:24:31 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:

>> David Holmes has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
>> 
>>  - Manpage update
>>  - Merge branch 'master' into 8297106-ensure-local-capacity
>>  - Removed additional test that no longer applies.
>>  - Forgot to commit deleted test file.
>>  - Forgot to commit removed test.
>>  - 8297106: Remove the -Xcheck:jni local reference capacity checking
>
> Thumbs up. The removal of -Xcheck:jni local reference capacity checking
> appears to be clean and easy to review.
> 
> The hard part is convincing yourself that there isn't a way to get
> something useful out of this idea.

Thanks @dcubed-ojdk 

> The hard part is convincing yourself that there isn't a way to get something useful out of this idea.

Yep totally agree. I kept trying but couldn't come up with anything useful. Ran it by some other folk and they agreed. All this feature seems to do is introduce periodic new test failures (across all releases).

-------------

PR: https://git.openjdk.org/jdk/pull/11259


More information about the hotspot-dev mailing list