RFR: 8295351: java/lang/Float/Binary16Conversion.java fails with "Unexpected result of converting" [v2]

Tobias Hartmann thartmann at openjdk.org
Mon Nov 28 07:44:28 UTC 2022


On Wed, 23 Nov 2022 19:58:41 GMT, Smita Kamath <svkamath at openjdk.org> wrote:

>> 8295351: java/lang/Float/Binary16Conversion.java fails with "Unexpected result of converting"
>
> Smita Kamath has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Addressed review comments

Looks reasonable to me.

src/hotspot/share/runtime/sharedRuntime.cpp line 472:

> 470:   }
> 471: 
> 472:   jint exp = ((0x7f800000 & doppel) >> (24 -1)) - 127;

Suggestion:

  jint exp = ((0x7f800000 & doppel) >> (24 - 1)) - 127;

-------------

Marked as reviewed by thartmann (Reviewer).

PR: https://git.openjdk.org/jdk/pull/11301


More information about the hotspot-dev mailing list