RFR: 8292741: Convert JvmtiTagMapTable to ResourceHashtable

Afshin Zafari duke at openjdk.org
Mon Nov 28 11:38:20 UTC 2022


On Mon, 28 Nov 2022 01:12:18 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> test of tier1-5 passed.
>
> src/hotspot/share/prims/jvmtiTagMap.cpp line 254:
> 
>> 252:       if (obj_tag != current_tag ) {
>> 253:         hashmap->remove(o);
>> 254:         hashmap->add(o, obj_tag);
> 
> This change is not atomic - is that a problem? The concurrency aspects of using this map are not clear.

add() is supposed to add a new object with tag. There is an assert() in its body that checks it. By removing the assert, add() can be used for updating as well.

-------------

PR: https://git.openjdk.org/jdk/pull/11288


More information about the hotspot-dev mailing list