RFR: 8292741: Convert JvmtiTagMapTable to ResourceHashtable

Afshin Zafari duke at openjdk.org
Mon Nov 28 11:44:23 UTC 2022


On Mon, 28 Nov 2022 01:20:49 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> test of tier1-5 passed.
>
> src/hotspot/share/prims/jvmtiTagMapTable.cpp line 77:
> 
>> 75: 
>> 76: void JvmtiTagMapTable::clear() {
>> 77:   struct RemoveAll{
> 
> Nit: space before {
> 
> Stylistically I'm not sure we define local structs like this when defining a "closure" object. ??

I have seen these local structs in some places in the code (e.g., in concurrentHashTable.hpp), therefore I used it this way. 
Any preference?

-------------

PR: https://git.openjdk.org/jdk/pull/11288


More information about the hotspot-dev mailing list