RFR: 8297697: RISC-V: Add support for SATP mode detection [v2]

Feilong Jiang fjiang at openjdk.org
Tue Nov 29 01:43:32 UTC 2022


On Mon, 28 Nov 2022 22:27:52 GMT, Ludovic Henry <luhenry at openjdk.org> wrote:

>> Feilong Jiang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   print vm mode string instead of vm mode code
>
> src/hotspot/cpu/riscv/vm_version_riscv.cpp line 43:
> 
>> 41:   VM_MODE mode = get_satp_mode();
>> 42:   if (mode > RISCV64_ONLY(VM_SV48) RISCV32_ONLY(VM_SV32)) {
>> 43:     vm_exit_during_initialization(err_msg("Unsupported satp mode: %d", mode));
> 
> I would map that number to a string. For example 10 to “sv48” so it is more googlable and searchable.

Thanks for the suggestion, actually we can just print `_vm_mode` since it already has mmu string.

-------------

PR: https://git.openjdk.org/jdk/pull/11388


More information about the hotspot-dev mailing list