RFR: 8297742: Combine vmTestbase/nsk/monitoring/ThreadMXBean/resetPeakThreadCount tests [v2]

Alex Menkov amenkov at openjdk.org
Tue Nov 29 02:36:13 UTC 2022


On Tue, 29 Nov 2022 01:12:52 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

>> Alex Menkov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Used multiple test tags
>
> test/hotspot/jtreg/vmTestbase/nsk/monitoring/ThreadMXBean/resetPeakThreadCount/reset001.java line 45:
> 
>> 43:  *
>> 44:  * @comment Direct access to the metrics.
>> 45:  * @run main/othervm nsk.monitoring.ThreadMXBean.resetPeakThreadCount.reset001
> 
> I think it would be better to have several @test id instead of multi @run for such cases. It allows for reporting the individual results for each run and executing them parallelly.

Good point. fixed.

-------------

PR: https://git.openjdk.org/jdk/pull/11400


More information about the hotspot-dev mailing list