RFR: 8297763: Fix missing stub code expansion before align() in shared trampolines [v2]

Xiaolin Zheng xlinzheng at openjdk.org
Wed Nov 30 11:39:33 UTC 2022


On Wed, 30 Nov 2022 09:45:22 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> Xiaolin Zheng has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix as to comments
>
> src/hotspot/cpu/aarch64/codeBuffer_aarch64.cpp line 55:
> 
>> 53:   auto emit = [&](address dest, const CodeBuffer::Offsets &offsets) {
>> 54:     masm.set_code_section(cb->stubs());
>> 55:     if (cb->stubs()->maybe_expand_to_ensure_remaining(NativeInstruction::instruction_size) && cb->blob() == NULL) {
> 
> Shoud we add a check for the real code alignment here and put maybe_expand_to_ensure_remaining() and masm.align(wordSize) operations under that check?

Thanks for the suggestion - yes, indeed.

-------------

PR: https://git.openjdk.org/jdk/pull/11414


More information about the hotspot-dev mailing list