RFR: 8288387: GetLocalXXX/SetLocalXXX spec should require suspending target thread

[Serguei Spitsyn]

On Thu, 6 Oct 2022 00:50:50 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

>> The spec of JVM TI GetLocalXXX/SetLocalXXX functions is updated to require the target thread to be suspended. If not suspended then the JVMTI_ERROR_THREAD_NOT_SUSPENDED error code is returned by the implementation.
>> 
>> The CSR is: https://bugs.openjdk.org/browse/JDK-8294690
>> 
>> A few tests are impacted by this fix:
>> 
>>  test/hotspot/jtreg/serviceability/jvmti/vthread/GetSetLocalTest
>>  test/hotspot/jtreg/serviceability/jvmti/vthread/VThreadTest
>>  test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/capability/CM01/cm01t011
>> 
>> 
>> The following test has been removed as non-relevant any more:
>> `  test/hotspot/jtreg/serviceability/jvmti/GetLocalVariable/GetLocalWithoutSuspendTest.java`
>>   
>> New negative test has been added instead:
>> `  test/hotspot/jtreg/serviceability/jvmti/GetLocalVariable/GetSetLocalUnsuspended.java`
>> 
>> All JVM TI and JPDA tests were used locally for verification.
>> They were also run in Loom repository with `JTREG_MAIN_WRAPPER=Virtual`. 
>> 
>> Mach5 test runs on all platforms are TBD.
>
> test/hotspot/jtreg/serviceability/jvmti/GetLocalVariable/GetSetLocalUnsuspended.java line 29:
> 
>> 27:  * @requires vm.continuations
>> 28:  * @library /test/lib
>> 29:  * @compile --enable-preview -source ${jdk.version} GetSetLocalUnsuspended.java
> 
> You could use * @enablePreview instead of --enable-preview

Good suggestion. It seems to be working.
But I had to remove the @compile line #29. I hope, it is okay.

-------------

PR: https://git.openjdk.org/jdk/pull/10586