Integrated: 8294366: RISC-V: Partially mark out incompressible regions

Xiaolin Zheng xlinzheng at openjdk.org
Sat Oct 8 16:00:03 UTC 2022


On Mon, 26 Sep 2022 12:19:15 GMT, Xiaolin Zheng <xlinzheng at openjdk.org> wrote:

> Shortly, the current RVC implementation in the RISC-V backend is a "whitelist mode", merely compressing instructions marked by "CompressibleRegion" that covers just part of C2 matching rules and stub code (only ~5% compression rate). Due to the originally existing large backend code base and to spread the coverage to nearly all instructions generated by the backend, we cannot modify them little by little, but should implement a "blacklist mode" (a compression rate to ~20% if complete), to exclude compressions from:
> 1. relocations
> 2. patchable instructions
> 3. fixed length code slices whose code size is calculated
> 
> Please check the discussions in the riscv-port mailing list[1] to go in for more details.
> 
> This patch contains the first half of implementations which does not change the program behavior: it just introduces an "IncompressibleRegion" to indicate a piece of code "not compressible", marking out the patchable instructions and fixed-length code slices that are not able to compress by RVC.
> 
> Besides, this patch also temporarily removes some automatic compression logic of branch instructions like "jal"s and "beq"s, for MachBranchNodes' fake labels could hamper the automatic compression as well and for making code clean. Please also check the discussions in the thread[1].
> 
> Please check the unsquashed commits to have a better review of the patch.
> 
> 
> Tested a hotspot tier1 and tier2 with the option UseRVC turning on.
> 
> [1] https://mail.openjdk.org/pipermail/riscv-port-dev/2022-September/000615.html
> 
> Thanks,
> Xiaolin

This pull request has now been integrated.

Changeset: 542cc602
Author:    Xiaolin Zheng <xlinzheng at openjdk.org>
Committer: Fei Yang <fyang at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/542cc602a7f023d3351133a321c4fa57249b8765
Stats:     111 lines in 8 files changed: 50 ins; 36 del; 25 mod

8294366: RISC-V: Partially mark out incompressible regions

Reviewed-by: fyang, yadongwang

-------------

PR: https://git.openjdk.org/jdk/pull/10421


More information about the hotspot-dev mailing list