RFR: 8294238: ZGC: Move CLD claimed mark clearing [v2]

[Thomas Schatzl]

On Tue, 11 Oct 2022 09:01:32 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> src/hotspot/share/classfile/classLoaderDataGraph.hpp line 69:
>> 
>>> 67:   static void clear_claimed_marks();
>>> 68:   static void clear_claimed_marks(int claim);
>>> 69:   static void verify_claimed_marks_cleared(int claim);
>> 
>> Is there a reason to not use `NOT_DEBUG_RETURN` for this method like for `ClassLoaderData::verify_not_claimed()`? I would prefer this to be consistent.
>
> I just think the NOT_DEBUG_RETURN / ASSERT macros pollute the code and makes it ugly to read, so I opted to not do it. This function is absolutely not performance critical, so I chose this approach.
> 
> I can be compelled to change it, if Reviewers prefer to change the code to use NOT_DEBUG_RETURN .

I am fine with the change as is, just noting that this change uses it in one place and does not in the other, which seemed inconsistent to me.

-------------

PR: https://git.openjdk.org/jdk/pull/10591