RFR: 8295023: Interpreter(AArch64): Implement -XX:+PrintBytecodeHistogram and -XX:+PrintBytecodePairHistogram options [v3]
Hao Sun
haosun at openjdk.org
Wed Oct 12 10:37:18 UTC 2022
On Wed, 12 Oct 2022 08:08:38 GMT, Andrew Haley <aph at openjdk.org> wrote:
>> Thanks for your review. But I'm afraid I didn't fully understand it.
>>
>> Why `generate_trace_code` is involved? I guess you mean `count_bytecode()`?
>> But `count_bytecode()` is invoked [here](https://github.com/openjdk/jdk/blob/master/src/hotspot/share/interpreter/templateInterpreterGenerator.cpp#L362), and I don't think it's a proper site to pass arch-specific register `r10` to the general `count_bytecode()`.
>>
>> Please correct me if I misunderstood. Thanks.
>
> Ah, I see what you mean.
> OK, just delete the name `rscratch3` and pass `r10` to `atomic_addw`. That simplifies the code to good effect.
Yes. Agree. Updated.
-------------
PR: https://git.openjdk.org/jdk/pull/10642
More information about the hotspot-dev
mailing list