RFR: 8295159: DSO created with -ffast-math breaks Java floating-point arithmetic

Wed Oct 12 11:31:26 UTC 2022

On Tue, 11 Oct 2022 16:02:41 GMT, Andrew Haley <aph at openjdk.org> wrote:

> A bug in GCC causes shared libraries linked with -ffast-math to disable denormal arithmetic. This breaks Java's floating-point semantics.
> 
> The bug is https://gcc.gnu.org/bugzilla/show_bug.cgi?id=55522
> 
> One solution is to save and restore the floating-point control word around System.loadLibrary(). This isn't perfect, because some shared library might load another shared library at runtime, but it's a lot better than what we do now. 
> 
> However, this fix is not complete. `dlopen()` is called from many places in the JDK. I guess the best thing to do is find and wrap them all. I'd like to hear people's opinions.

I think this looks okay from a build perspective. I second David's opinion that the empty file should have a comment explaining that it exists to be compiled with a special flag.

-------------

Marked as reviewed by ihse (Reviewer).

PR: https://git.openjdk.org/jdk/pull/10661