RFR: 8295270: RISC-V: Clean up and refactoring for assembler functions [v2]

Fei Yang fyang at openjdk.org
Thu Oct 13 13:32:32 UTC 2022


On Thu, 13 Oct 2022 12:54:57 GMT, Feilong Jiang <fjiang at openjdk.org> wrote:

>> Fei Yang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix name of locals
>
> src/hotspot/cpu/riscv/macroAssembler_riscv.hpp line 678:
> 
>> 676:       Assembler::NAME(Rd, Rd, ((int32_t)offset << 20) >> 20);                                      \
>> 677:     } else {                                                                                       \
>> 678:       int32_t offset = 0;                                                                          \
> 
> It might be confusing that we have already defined `offset` in L673 with a different type.

Fixed. Thanks for pointing this out.

-------------

PR: https://git.openjdk.org/jdk/pull/10697


More information about the hotspot-dev mailing list