RFR: 8137022: Concurrent refinement thread adjustment and (de-)activation suboptimal [v6]

[Kim Barrett]

On Mon, 17 Oct 2022 08:28:29 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> Kim Barrett has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 22 commits:
>> 
>>  - adjust young target length periodically
>>  - use cards in thread-buffers when revising young list target length
>>  - remove remset sampler
>>  - move remset-driven young-gen resizing
>>  - fix type of predict_dirtied_cards_in_threa_buffers
>>  - Merge branch 'master' into crt2
>>  - comments around alloc_bytes_rate being zero
>>  - tschatzl comments
>>  - changed threads wanted logging per kstefanj
>>  - s/max_cards/mutator_refinement_threshold/
>>  - ... and 12 more: https://git.openjdk.org/jdk/compare/8487c56f...1631a61a
>
> src/hotspot/share/gc/g1/g1ConcurrentRefine.cpp line 309:
> 
>> 307: // the remembered sets (and many other components), so this thread constantly
>> 308: // reevaluates the prediction for the remembered set scanning costs, and potentially
>> 309: // G1Policy resizes the young gen. This may do a premature GC or even
> 
> Suggestion:
> 
> // resizes the young gen. This may do a premature GC or even
> 
> I think this flows better with that word removed, feel free to ignore.

Done.

> src/hotspot/share/gc/g1/g1ConcurrentRefine.hpp line 146:
> 
>> 144:   uint64_t adjust_threads_period_ms() const;
>> 145:   bool is_in_last_adjustment_period() const;
>> 146:   class RemSetSamplingClosure;
> 
> Suggestion:
> 
> 
>   class RemSetSamplingClosure;
> 
> 
> Maybe an added newline to emphasize that declaration.

Done.

-------------

PR: https://git.openjdk.org/jdk/pull/10256