Integrated: JDK-8293711: Factor out size parsing functions from arguments.cpp

Thomas Stuefe stuefe at openjdk.org
Mon Oct 17 12:48:01 UTC 2022


On Tue, 13 Sep 2022 15:19:34 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

> Arguments.cpp has several size parsing functions which would be useful in other areas of the hotspot, e.g. in NMT.
> 
> It would be nice to have them factored out into utilities, to reuse the code and to unify memory size handling. Gtests would be good too.
> 
> To simplify reviews, I split the patch into two commits.
> 
> The first commit (https://github.com/openjdk/jdk/pull/10252/commits/700e77e8d1469a2fc3d6611072c4b07aa34ab8e6) contains the unchanged code move without functional changes.
> 
> The second commit (https://github.com/openjdk/jdk/pull/10252/commits/76b4f6f30cc316fd966da60ff6601f54eeb394bf) contains the functional changes I did, as well as the new gtest.

This pull request has now been integrated.

Changeset: ec2981b8
Author:    Thomas Stuefe <stuefe at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/ec2981b83bc3ef6977b5f16d5222eb49b0ea49ad
Stats:     449 lines in 6 files changed: 339 ins; 110 del; 0 mod

8293711: Factor out size parsing functions from arguments.cpp

Reviewed-by: dholmes, jsjolen

-------------

PR: https://git.openjdk.org/jdk/pull/10252


More information about the hotspot-dev mailing list