RFR: 8295646: Ignore zero pairs in address descriptors read by dwarf parser

Xiaolin Zheng xlinzheng at openjdk.org
Wed Oct 19 10:33:55 UTC 2022


On Wed, 19 Oct 2022 10:18:59 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

> We could additionally assert that the real terminating entry is indeed `(0, 0)` as specified in the spec. But you need to check if that is the case on RISC-V.

Thanks for your time for reviewing! In fact, before submitting this PR I had one assertion to assert when the new `is_terminating_entry()` returns true, we must encounter a pair of zero. Though I removed it at last because I wanted to fully mirror what Binutils is doing. Of course, I think the assertion is reasonable and on RISC-V it is the same case that the real terminating entry is a pair of 0. So going to add that assertion back.

-------------

PR: https://git.openjdk.org/jdk/pull/10758


More information about the hotspot-dev mailing list