RFR: 8295060: Port PrintDeoptimizationDetails to UL [v3]

Coleen Phillimore coleenp at openjdk.org
Wed Oct 19 18:05:24 UTC 2022


On Wed, 19 Oct 2022 09:00:14 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

>> Hi!
>> 
>> This PR ports PrintDeoptimizationDetails to UL by mapping its output to debug level with tag deoptimization.
>
> Johan Sjölen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove unnecessary -Xlog:disable

Looks good to me.

src/hotspot/share/runtime/vframeArray.cpp line 460:

> 458:       vframe* f = vframe::new_vframe(iframe(), &map, thread);
> 459:       f->print_on(&ls);
> 460:       if (WizardMode && Verbose) method()->print_codes_on(&ls);

I guess David already commented on this but we're trying to remove WizardMode and Verbose.  Can this be:
if (lm.is_trace()) method->print_codes_on(lm);
?
Also methodHandle doesn't require () because -> turns it into Method*.

-------------

Marked as reviewed by coleenp (Reviewer).

PR: https://git.openjdk.org/jdk/pull/10645


More information about the hotspot-dev mailing list