RFR: 8280131: jcmd reports "Module jdk.jfr not found." when "jdk.management.jfr" is missing [v2]

Erik Gahlin egahlin at openjdk.org
Thu Oct 20 13:16:28 UTC 2022


> Could I have a review of a PR that ensures JFR can be used when only the jdk.jfr module is present in an image.
> 
> The behavior is similar to how  -javaagent  adds the java.instrument module and "jcmd PID ManagementAgent.status" loads the jdk.management.agent module.
> 
> TestJfrJavaBase.java is replaced with TestModularImage.java. The former test could not be used since the jdk.jfr module is now added to the module graph when -XX:StartFlightRecording is specified.
> 
> Testing: tier1-3 + test/jdk/jdk/jfr
> 
> Thanks
> Erik

Erik Gahlin has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:

 - Merge branch 'master' of https://github.com/openjdk/jdk into moddda
 - Fix disabled
 - Fix pointer format
 - Initial

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/10723/files
  - new: https://git.openjdk.org/jdk/pull/10723/files/e5035b14..7b41be0f

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=10723&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=10723&range=00-01

  Stats: 18465 lines in 1007 files changed: 8888 ins; 6070 del; 3507 mod
  Patch: https://git.openjdk.org/jdk/pull/10723.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/10723/head:pull/10723

PR: https://git.openjdk.org/jdk/pull/10723


More information about the hotspot-dev mailing list