RFR: 8233697: CHT: Iteration parallelization [v3]

Ivan Walulya iwalulya at openjdk.org
Fri Oct 21 09:06:28 UTC 2022


On Fri, 21 Oct 2022 06:37:54 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> Ivan Walulya has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - move BucketsClaimer declaration
>>  - move BucketsClaimer declaration
>
> src/hotspot/share/utilities/concurrentHashTable.inline.hpp line 1358:
> 
>> 1356:     }
>> 1357:     return false;
>> 1358:   }
> 
> Minor nit: A better place for this method is probably `InternalTableClaimer`; then you can also probably improve encapsulation (visibility) of the members if you want, but I'm good with keeping everything public (as default for a struct) for this helper class.
> I did not think through the suggestion earlier.

you are right, i have updated, not certain about the `_table_claimer` and `_new_table_claimer` names, but couldn't come up with better

-------------

PR: https://git.openjdk.org/jdk/pull/10759


More information about the hotspot-dev mailing list