RFR: 8295118: G1: Clear CLD claim marks concurrently [v2]
Stefan Johansson
sjohanss at openjdk.org
Tue Oct 25 08:41:43 UTC 2022
On Tue, 25 Oct 2022 08:36:11 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:
>> Hi all,
>>
>> can I have reviews for this change that moves out clearing CLD marks from the concurrent start pause to the concurrent phase?
>>
>> The idea is that instead of clearing CLD marks just before marking through, clear the marks at the end of the concurrent phases (or at the end of the full gc) so that after that operation marks are reset.
>>
>> I believe that one can save one of the `ClassLoaderDataGraph::clear_claimed_marks` in full gc by using different claim values (we need the one at the beginning and the end though), but the overhead of that should be minimal compared to actual full gc time.
>>
>> Testing: tier1-5
>
> Thomas Schatzl has updated the pull request incrementally with two additional commits since the last revision:
>
> - sjohanss review fixes
> - sjohanss review
Thanks, please revert the changes to `g1FullGCCompactTask.*` or at least remove the additional include in the cpp-file before pushing.
-------------
Marked as reviewed by sjohanss (Reviewer).
PR: https://git.openjdk.org/jdk/pull/10675
More information about the hotspot-dev
mailing list