RFR: 8295711: Rename ZBarrierSetAssembler::load_at parameter name from "tmp_thread" to "tmp2"
Fei Yang
fyang at openjdk.org
Wed Oct 26 08:19:22 UTC 2022
On Fri, 21 Oct 2022 07:06:31 GMT, Fei Yang <fyang at openjdk.org> wrote:
> > Please also fix the `tmp_thread` parameter for x86 while you are at it ;)
>
> It looks to me that the case for x86 is different here. For x86_32, this formal parameter will be used later for calling 'get_thread()' [1][2]. So I think we should keep its original name.
>
> [1] https://github.com/openjdk/jdk/blob/master/src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetAssembler_x86.cpp#L573
>
> [2] https://github.com/openjdk/jdk/blob/master/src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetAssembler_x86.cpp#L573
@tschatzl : Are you OK with this? And any further comments? Thanks.
-------------
PR: https://git.openjdk.org/jdk/pull/10783
More information about the hotspot-dev
mailing list