RFR: 8294729: [s390] Implement nmethod entry barriers
Lutz Schmidt
lucy at openjdk.org
Wed Oct 26 20:00:39 UTC 2022
On Tue, 11 Oct 2022 15:14:19 GMT, Tyler Steele <tsteele at openjdk.org> wrote:
>> Good idea! One instruction instead of two, plus avoiding a data interlock when loading the constant address.
>
> I made this change. Though I do want to confirm that `__ z_larl(Z_R1_scratch, StubRoutines::zarch::nmethod_entry_barrier());` is the correct version, and not `&StubRoutines::zarch::nmethod_entry_barrier()` which is also mentioned above. Since nmethod_entry_barrier returns an `address` (and address is already a `char*`) I don't believe we want the ampersand.
You are right. We don't want the '&'. I first assumed (disregarding the parentheses) this would be a field where the address of a generated stub is stored.
-------------
PR: https://git.openjdk.org/jdk/pull/10558
More information about the hotspot-dev
mailing list