RFR: 8293100: RISC-V: Need to save and restore callee-saved FloatRegisters in StubGenerator::generate_call_stub [v2]

Xiaolin Zheng xlinzheng at openjdk.org
Thu Sep 1 09:15:19 UTC 2022


On Thu, 1 Sep 2022 08:54:36 GMT, Feilong Jiang <fjiang at openjdk.org> wrote:

>> Xiaolin Zheng has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Revise comments
>
> src/hotspot/cpu/riscv/stubGenerator_riscv.cpp line 131:
> 
>> 129:   //      ...
>> 130:   // -34 [ argument word 1      ]
>> 131:   // -33 [ saved f27            ] <--- sp_after_call
> 
> I think it's better to add some comments about saving FloatRegisters at line 124.

Thank you, always forget the comment things. Seems x9 is also missed in the comments; it is added along with f8-f9 and f18-f27 now.

-------------

PR: https://git.openjdk.org/jdk/pull/10095


More information about the hotspot-dev mailing list