RFR: 8292981: Unify and restructure integer printing format specifiers [v10]
Stefan Karlsson
stefank at openjdk.org
Thu Sep 1 16:33:13 UTC 2022
> Today we have some inconsistencies in how we name our integer printing format specifiers. I'd like to change this to be consistent.
>
> This patch comes from a discussion in #10028, which snowballed into restructuring the format specifiers. The main issues was that my original patch used PTR<size>_FORMAT to print integers with the format 0x000<value>. The reviewers felt that it was wrong to use PTR format specifiers when printing integers. I agree with that.
>
> We do have format specifiers to print hex values out of integers, though they don't 0-pad like the PTR macros do, and only some of the prepend 0x.
>
> I'd like to suggest that we use a convention to specify what we want. This is the current proposal:
>
> // Guide to the suffixes used in the format specifiers for integers:
> // - print the decimal value: 745565
> // _X - print as hexadecimal, without leading 0s: 0x12345
> // _X_0 - print as hexadecimal, with leading 0s: 0x00012345
> // _H - print as hexadecimal, without 0x prefix
> // _W(w) - prints w sized string with the given value right
> // adjusted. Use -w to print left adjusted.
> //
> // Note that the PTR format specifiers print using 0x with leading zeros,
> // just like the _X_0 version for integers.
>
>
> The patch also removes PTR32_FORMAT and PTR64_FORMAT and replace them with the corresponding integer format specifiers.
Stefan Karlsson has updated the pull request incrementally with one additional commit since the last revision:
Fix gtest compilation warning
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/10042/files
- new: https://git.openjdk.org/jdk/pull/10042/files/7679fdd0..736b9c2e
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=10042&range=09
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=10042&range=08-09
Stats: 47 lines in 1 file changed: 0 ins; 0 del; 47 mod
Patch: https://git.openjdk.org/jdk/pull/10042.diff
Fetch: git fetch https://git.openjdk.org/jdk pull/10042/head:pull/10042
PR: https://git.openjdk.org/jdk/pull/10042
More information about the hotspot-dev
mailing list