RFR: 8293254: x86_64: Extract arraycopy stub implementations into a separate file
Vladimir Kozlov
kvn at openjdk.org
Thu Sep 1 21:29:30 UTC 2022
On Thu, 1 Sep 2022 20:30:37 GMT, Vladimir Ivanov <vlivanov at openjdk.org> wrote:
> Move arraycopy stub implementations from `stubGenerator_x86_64.cpp` into `stubGenerator_x86_64_arraycopy.cpp`.
>
> Testing: hs-tier1 - hs-tier4
>
> PS: FTR I left `MacroAssembler::generate_fill_avx3()` intact because it is called from `MacroAssembler::generate_fill()` which is shared between x86_64 and x86_32. Otherwise, I would either need to copy `MacroAssembler::generate_fill()` or put it into a separate file (e.g., `stubGenerator_x86.cpp` or `stubGenerator_x86_arraycopy.cpp`). IMO it doesn't add much value compared to keeping it in `macroAssembler_x86.cpp`.
Good. I agree with you about not moving `generate_fill_avx3`.
-------------
Marked as reviewed by kvn (Reviewer).
PR: https://git.openjdk.org/jdk/pull/10128
More information about the hotspot-dev
mailing list