RFR: 8293287 add ReplayReduce flag [v2]
Dean Long
dlong at openjdk.org
Sat Sep 3 02:58:38 UTC 2022
On Sat, 3 Sep 2022 00:51:45 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:
> Can you explain the issue with this test and your changes? New code should be off by default.
I had to move the call to reset() (which clears parsing errors) to allow multiple compile commands. This revealed an existing problem with compiler/ciReplay/TestVMNoCompLevel.java. This test removes the last token from the "compile" line, trying to simulate a pre-2013 replay file. Removing the last token is wrong if there are inlining tokens. I could fix the test, but I don't see the value. I don't think a 2022 JVM needs to read pre-2013 replay files. If necessary, an old replay file can be edited to allow it to be parsed by a recent JVM. I proposed to deleted the test and related workarounds in the code.
-------------
PR: https://git.openjdk.org/jdk/pull/10134
More information about the hotspot-dev
mailing list