RFR: 8293254: x86_64: Extract arraycopy stub implementations into a separate file [v3]

Vladimir Ivanov vlivanov at openjdk.org
Tue Sep 6 22:17:45 UTC 2022


On Fri, 2 Sep 2022 23:19:30 GMT, Vladimir Ivanov <vlivanov at openjdk.org> wrote:

>> Move arraycopy stub implementations from `stubGenerator_x86_64.cpp` into `stubGenerator_x86_64_arraycopy.cpp`.
>> 
>> Testing: hs-tier1 - hs-tier4
>> 
>> PS: FTR I left `MacroAssembler::generate_fill_avx3()` intact because it is called from `MacroAssembler::generate_fill()` which is shared between x86_64 and x86_32. Otherwise, I would either need to copy `MacroAssembler::generate_fill()` or put it into a separate file (e.g., `stubGenerator_x86.cpp` or `stubGenerator_x86_arraycopy.cpp`). IMO it doesn't add much value compared to keeping it in `macroAssembler_x86.cpp`.
>
> Vladimir Ivanov has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains six commits:
> 
>  - Merge branch 'master' into stub.x86_64.arraycopy
>  - arraycopy stubs
>  - fix hs-minimal build
>  - update
>  - fix
>  - stubGenerator_x86_64.hpp

Thanks for the reviews, Dean and Vladimir.

-------------

PR: https://git.openjdk.org/jdk/pull/10128


More information about the hotspot-dev mailing list