RFR: 8293329: x86: Improve handling of constants in AES/GHASH stubs [v2]
Vladimir Ivanov
vlivanov at openjdk.org
Tue Sep 6 22:29:10 UTC 2022
> Pre-generating constants saves on startup and static/dynamic footprint a bit, plus simplifies bootstrapping logic.
>
> As a downside, constants aren't guaranteed to be always reachable anymore, but since they are used from stubs, finding a scratch register when needed is not a problem.
>
> Testing:
> - [x] hs-tier1 - hs-tier4 w/ `-XX:+ForceUnreachable`
> - [x] x86_32 build
Vladimir Ivanov has updated the pull request incrementally with 41 additional commits since the last revision:
- Merge branch 'stub.x86_64.aes' into stub.x86_64.aes.consts
- Merge branch 'master' into stub.x86_64.aes
- 8293285: x86_64: Move libm stub implementations to StubGenerator
Reviewed-by: kvn
- 8293254: x86_64: Extract arraycopy stub implementations into a separate file
Reviewed-by: dlong, kvn
- 8293245: x86_64: Extract Adler32 stub implementation into stubGenerator_x86_64_adler.cpp
Reviewed-by: kvn, dlong
- 8264744: (fs) Use file cloning in Linux version of Files::copy method
Reviewed-by: alanb
- 8283929: GHA: Add RISC-V build config
Reviewed-by: ihse, shade
- 8292579: (tz) Update Timezone Data to 2022c
Reviewed-by: naoto, alanb
- 8293403: JfrResolution::on_jvmci_resolution crashes when caller is null
Reviewed-by: never
- 8291736: find_method_handle_intrinsic leaks Method*
Reviewed-by: hseigel, iklam, dholmes
- ... and 31 more: https://git.openjdk.org/jdk/compare/20d589e3...7c35132b
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/10152/files
- new: https://git.openjdk.org/jdk/pull/10152/files/20d589e3..7c35132b
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=10152&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=10152&range=00-01
Stats: 33649 lines in 190 files changed: 16839 ins; 16134 del; 676 mod
Patch: https://git.openjdk.org/jdk/pull/10152.diff
Fetch: git fetch https://git.openjdk.org/jdk pull/10152/head:pull/10152
PR: https://git.openjdk.org/jdk/pull/10152
More information about the hotspot-dev
mailing list