RFR: 8292671: Hotspot Style Guide should allow covariant returns [v2]

Roland Westrelin roland at openjdk.org
Fri Sep 9 11:44:49 UTC 2022


On Mon, 22 Aug 2022 05:02:48 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> Roland Westrelin has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   remove Covariant return types from list of allowed features
>
> doc/hotspot-style.md line 1073:
> 
>> 1071: ([n2544](http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2008/n2544.pdf))
>> 1072: 
>> 1073: * Covariant return types
> 
> Covariant return types are a C++03 feature, so are covered by the blanket
> permission for such here:
> https://github.com/openjdk/jdk/blame/master/doc/hotspot-style.md#L385-L386
> 
> So the exclusion could be just deleted, rather than changing to explicit
> permission.  Though an argument for explicit permission is to make the removal
> of the long-standing exclusion more obvious.  I'm fine with either, but
> thought it was worth mentioning.

Thanks for the clarification. I removed the explicit permission.

-------------

PR: https://git.openjdk.org/jdk/pull/9941


More information about the hotspot-dev mailing list