RFR: 8293566: RISC-V: Clean up push and pop registers [v2]

Feilong Jiang fjiang at openjdk.org
Sun Sep 11 02:07:55 UTC 2022


> Currently, riscv port has two implementations of `push_reg` and `pop_reg`.
> The bitset version can be replaced with the RegSet version for better readability.
> 
> For example, if we want to push x10 and x11, pushing register with bitset would be like:
> 
> push_reg(0xc00, sp)
> 
> 
> while pushing register with RegSet will be more clear:
> 
> push_reg(RegSet::of(x10, x11), sp);
> 
> 
> So we decide to remove the bitset version of push and pop registers.
> 
> Testing:
> 
> - hotspot and jdk ter1 on QEMU without new failures

Feilong Jiang has updated the pull request incrementally with two additional commits since the last revision:

 - fix comment
 - restore bitset routine

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/10227/files
  - new: https://git.openjdk.org/jdk/pull/10227/files/25a10eee..441d50c6

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=10227&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=10227&range=00-01

  Stats: 47 lines in 3 files changed: 25 ins; 0 del; 22 mod
  Patch: https://git.openjdk.org/jdk/pull/10227.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/10227/head:pull/10227

PR: https://git.openjdk.org/jdk/pull/10227


More information about the hotspot-dev mailing list