RFR: 8293329: x86: Improve handling of constants in AES/GHASH stubs [v5]

Vladimir Ivanov vlivanov at openjdk.org
Mon Sep 12 22:55:54 UTC 2022


On Fri, 9 Sep 2022 00:35:47 GMT, Vladimir Ivanov <vlivanov at openjdk.org> wrote:

>> Pre-generating constants saves on startup and static/dynamic footprint a bit, plus simplifies bootstrapping logic. 
>> 
>> As a downside, constants aren't guaranteed to be always reachable anymore, but since they are used from stubs, finding a scratch register when needed is not a problem.
>> 
>> Testing: 
>> - [x] hs-tier1 - hs-tier4 w/ `-XX:+ForceUnreachable` 
>> - [x] x86_32 build
>
> Vladimir Ivanov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fix merge

Thanks for the review, Vladimir.

-------------

PR: https://git.openjdk.org/jdk/pull/10152


More information about the hotspot-dev mailing list