RFR: 8293660: Fix frame::sender_for_compiled_frame frame size assert [v2]
Aleksey Shipilev
shade at openjdk.org
Tue Sep 13 06:08:35 UTC 2022
On Tue, 13 Sep 2022 03:10:59 GMT, Dean Long <dlong at openjdk.org> wrote:
> This looks fine. You could probably even use >= 2. More correct would probably be >= metadata_words,
> but some ports are setting that value to 0, which will probably break things with loom.
Yeah, I'd prefer to keep the most accepting form. It seems we really want to catch the zero case to guarantee stack walking progress.
> There are also some places under hotspot/agent/src/share/classes that are doing the equivalent in Java:
> Assert.that(cb.getFrameSize() > 0, "CodeBlob must have non-zero frame size");
> which would probably be low-risk to fix in this PR if you wanted.
Fixed those in new commit.
-------------
PR: https://git.openjdk.org/jdk/pull/10242
More information about the hotspot-dev
mailing list