RFR: 8293680: PPC64BE build failure after JDK-8293344

Aleksey Shipilev shade at openjdk.org
Tue Sep 13 07:22:03 UTC 2022


On Tue, 13 Sep 2022 07:11:22 GMT, Jie Fu <jiefu at openjdk.org> wrote:

>> The bug manifests on PPC64, since `section_by_name` is protected by `#if defined(PPC64) && !defined(ABI_ELFv2)`:
>> 
>> 
>> * For target hotspot_variant-server_libjvm_objs_elfFile.o:
>
> src/hotspot/share/utilities/elfFile.cpp line 37:
> 
>> 35: #include "logging/log.hpp"
>> 36: #include "memory/allocation.inline.hpp"
>> 37: #include "memory/resourceArea.hpp"
> 
> Shall we only include `resourceArea.hpp` for `defined(PPC64) && !defined(ABI_ELFv2)`?

I don't like complicated include guards in include blocks, so I'd prefer not to.

-------------

PR: https://git.openjdk.org/jdk/pull/10247


More information about the hotspot-dev mailing list