Integrated: 8293595: tstrings::any() is missing an overload
Julian Waters
jwaters at openjdk.org
Tue Sep 20 13:08:15 UTC 2022
On Fri, 9 Sep 2022 13:38:14 GMT, Julian Waters <jwaters at openjdk.org> wrote:
> tstrings::any() has an overload for std::wstring (if required) but is missing the corresponding operator overload for std::string, leaving only the templated one as a fallback, which will expand into a std::wostringstream << std::string operation. This isn't particularly safe on Windows, considering that JDK-8292008 and JDK-8247283 have been recently merged, and can sporadically cause build failures. This change simply adds the missing overload with the appropriate format handling that jpackage expects from std::string. Also contains minor name changes to fit the rest of the parameter names in the other overloads.
This pull request has now been integrated.
Changeset: bb422f5c
Author: Julian Waters <jwaters at openjdk.org>
Committer: Alexey Semenyuk <asemenyuk at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/bb422f5c14745bf29bc2cb741f819a17c8400543
Stats: 11 lines in 1 file changed: 5 ins; 0 del; 6 mod
8293595: tstrings::any() is missing an overload
Reviewed-by: asemenyuk, almatvee
-------------
PR: https://git.openjdk.org/jdk/pull/10231
More information about the hotspot-dev
mailing list