RFR: JDK-8293711: Factor out size parsing functions from arguments.cpp

Thomas Stuefe stuefe at openjdk.org
Tue Sep 20 15:13:44 UTC 2022


On Tue, 20 Sep 2022 14:33:45 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

>> Arguments.cpp has several size parsing functions which would be useful in other areas of the hotspot, e.g. in NMT.
>> 
>> It would be nice to have them factored out into utilities, to reuse the code and to unify memory size handling. Gtests would be good too.
>> 
>> To simplify reviews, I split the patch into two commits.
>> 
>> The first commit (https://github.com/openjdk/jdk/pull/10252/commits/700e77e8d1469a2fc3d6611072c4b07aa34ab8e6) contains the unchanged code move without functional changes.
>> 
>> The second commit (https://github.com/openjdk/jdk/pull/10252/commits/76b4f6f30cc316fd966da60ff6601f54eeb394bf) contains the functional changes I did, as well as the new gtest.
>
> test/hotspot/gtest/utilities/test_parse_memory_size.cpp line 41:
> 
>> 39: 
>> 40: #define LOG(s, ...) LOG_HERE(s, __VA_ARGS__)
>> 41: //#define LOG(s, ...)
> 
> Forgot to remove this?

:-) Yes, you are right.

-------------

PR: https://git.openjdk.org/jdk/pull/10252


More information about the hotspot-dev mailing list