RFR: JDK-8293711: Factor out size parsing functions from arguments.cpp [v2]

[David Holmes]

On Tue, 20 Sep 2022 15:23:58 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Arguments.cpp has several size parsing functions which would be useful in other areas of the hotspot, e.g. in NMT.
>> 
>> It would be nice to have them factored out into utilities, to reuse the code and to unify memory size handling. Gtests would be good too.
>> 
>> To simplify reviews, I split the patch into two commits.
>> 
>> The first commit (https://github.com/openjdk/jdk/pull/10252/commits/700e77e8d1469a2fc3d6611072c4b07aa34ab8e6) contains the unchanged code move without functional changes.
>> 
>> The second commit (https://github.com/openjdk/jdk/pull/10252/commits/76b4f6f30cc316fd966da60ff6601f54eeb394bf) contains the functional changes I did, as well as the new gtest.
>
> Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision:
> 
>   feedback johan

Basic moving of the parsing functions to their own header file (modulo the naming of that file) seems okay. But I don't follow the "memory size" aspect of this refactoring. ??

src/hotspot/share/runtime/arguments.cpp line 63:

> 61: #include "utilities/defaultStream.hpp"
> 62: #include "utilities/macros.hpp"
> 63: #include "utilities/parse_memory_size.hpp"

File names use camelCase naming.

-------------

Changes requested by dholmes (Reviewer).

PR: https://git.openjdk.org/jdk/pull/10252