RFR: JDK-8293711: Factor out size parsing functions from arguments.cpp [v2]

Thomas Stuefe stuefe at openjdk.org
Wed Sep 21 06:21:45 UTC 2022


On Wed, 21 Sep 2022 05:18:20 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   feedback johan
>
> test/hotspot/gtest/testutils.hpp line 60:
> 
>> 58: 
>> 59: #define LOG_HERE(s, ...) { printf(s, __VA_ARGS__); printf("\n"); fflush(stdout); }
>> 60: 
> 
> In other reviews I've asked the reviewers to use unified logging with the `test` tag. Maybe do the same for this test?

Unfortunately, UL is not an option here, since I use it in TEST tests (without _VM, so I may not have VM infrastructure available depending on the order of test execution).

-------------

PR: https://git.openjdk.org/jdk/pull/10252


More information about the hotspot-dev mailing list