RFR: JDK-8293711: Factor out size parsing functions from arguments.cpp [v2]

Thomas Stuefe stuefe at openjdk.org
Wed Sep 21 07:08:47 UTC 2022


On Wed, 21 Sep 2022 06:52:47 GMT, David Holmes <dholmes at openjdk.org> wrote:

> > Before we had:
> > A) parse_integer() -> does not parse integer, but memory sizes, e.g. "1K", "1G", etc
> 
> Hmmm, I don't consider those "memory sizes" even if often used for such they are just ways of expressing large integers in a simple way. They are used for file sizes and data-structure sizes as well.

I'm unemotional about the name as long as its clearly different from a simple integer parsing. 

How about "parse_size" ? "parse_si_size" ? (though we don't implement the full complement of si units). "parse_size_with_units" ?

-------------

PR: https://git.openjdk.org/jdk/pull/10252


More information about the hotspot-dev mailing list