RFR: JDK-8293711: Factor out size parsing functions from arguments.cpp [v3]

[David Holmes]

On Wed, 21 Sep 2022 06:31:22 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Arguments.cpp has several size parsing functions which would be useful in other areas of the hotspot, e.g. in NMT.
>> 
>> It would be nice to have them factored out into utilities, to reuse the code and to unify memory size handling. Gtests would be good too.
>> 
>> To simplify reviews, I split the patch into two commits.
>> 
>> The first commit (https://github.com/openjdk/jdk/pull/10252/commits/700e77e8d1469a2fc3d6611072c4b07aa34ab8e6) contains the unchanged code move without functional changes.
>> 
>> The second commit (https://github.com/openjdk/jdk/pull/10252/commits/76b4f6f30cc316fd966da60ff6601f54eeb394bf) contains the functional changes I did, as well as the new gtest.
>
> Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Feedback stefank+dholmes

I'm not sure why you need to have two different parsing routines when one routine can parse everything. Things like 1K, 1M etc are defined by Unicode as "compact number formats", so you could incorporate that in the name if you had to, but I don't see why you want/need to.

-------------

PR: https://git.openjdk.org/jdk/pull/10252