RFR: 8294087: RISC-V: RVC: Fix a potential alignment issue and add more alignment assertions for the patchable calls/nops [v2]
Xiaolin Zheng
xlinzheng at openjdk.org
Wed Sep 21 10:31:39 UTC 2022
On Wed, 21 Sep 2022 10:16:21 GMT, Xiaolin Zheng <xlinzheng at openjdk.org> wrote:
>> With RVC turning on, we must carefully keep all runtime-patchable instructions aligned. Code is running at full speed, when patching unaligned instructions spanning cache lines, concurrency issues may occur. This patch fixes a potential alignment issue of the patchable nop after MachUEPNode, with adding some strong alignment assertions as well. (In fact, currently the `nop` in the Verified Entry Point is fortunately aligned to 4 under RVC even without this patch, so this patch doesn't change program behaviors.)
>>
>> Tested hotspot tier1 and tier2 together with other patches on QEMU.
>
> Xiaolin Zheng has updated the pull request incrementally with two additional commits since the last revision:
>
> - Modifications as to review comments
> - RISC-V: Fix a potential alignment issue and add more alignment assertions for the patchable calls/nops
> Can you add in the code alignment assertions introduced by your new RVC proposal [1]?
>
> [1] [zhengxiaolinX at 2687452](https://github.com/zhengxiaolinX/jdk/commit/26874527d196cd6c31b1649c8c00ed4f5a6b154a)
Of course, I have added that and modified the title and descriptions of this PR.
-------------
PR: https://git.openjdk.org/jdk/pull/10370
More information about the hotspot-dev
mailing list