RFR: 8294087: RISC-V: RVC: Fix a potential alignment issue and add more alignment assertions for the patchable calls/nops [v7]

Xiaolin Zheng xlinzheng at openjdk.org
Thu Sep 22 06:41:48 UTC 2022


On Thu, 22 Sep 2022 06:06:32 GMT, Feilong Jiang <fjiang at openjdk.org> wrote:

>> Xiaolin Zheng has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Simply unify a remaining assertion
>
> src/hotspot/cpu/riscv/c1_LIRAssembler_riscv.cpp line 1375:
> 
>> 1373: void LIR_Assembler::emit_static_call_stub() {
>> 1374:   address call_pc = __ pc();
>> 1375:   __ assert_alignment(call_pc);
> 
> As `assert_alignment` is defined as a  static method, there is no need for `__`. `MacroAssembler::assert_alignment(call_pc)` would be better.

Reasonable; all done.

-------------

PR: https://git.openjdk.org/jdk/pull/10370


More information about the hotspot-dev mailing list