RFR: 8292699: Improve printing of classes in native debugger [v7]

[Ioi Lam]

On Mon, 22 Aug 2022 19:24:33 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Use proper locking
>
> src/hotspot/share/interpreter/bytecodeTracer.cpp line 434:
> 
>> 432:     // TODO: print info for tag.is_dynamic_constant()
>> 433:   }
>> 434: }
> 
> This should be a function in ConstantPool::print()

This block of code works on an `indy_index`, which is stored only inside the bytecode stream (it's the rewritten index of the [invokedynamic bytecode](https://docs.oracle.com/javase/specs/jvms/se17/html/jvms-6.html#jvms-6.5.invokedynamic). `indy_index` is not store anywhere inside the `ConstantPool`, so I can't find a good place to print this info in the printing functions of `ConstantPool`.

Note that you can have multiple `invokedynamic` bytecodes that use the same `JVM_CONSTANT_InvokeDynamic` entry in a `ConstantPool`, resulting in a different  `indy_index` for each call site. Therefore, this per-callsite information cannot be printed as part of the `JVM_CONSTANT_InvokeDynamic` entry

> src/hotspot/share/interpreter/bytecodeTracer.cpp line 462:
> 
>> 460:     }
>> 461:   }
>> 462: }
> 
> Line 444-461 should call a function in cpCache like:
> void ConstantPoolCacheEntry::print(outputStream* st, int index) const {
> 
> If this doesn't have the format you want, you can enhance this function.

I moved this code to `ConstantPoolCacheEntry::print` in version [e4afb9f](https://github.com/openjdk/jdk/pull/9957/commits/e4afb9fa235551ef98ccca408aeba4c18bf9904c)

-------------

PR: https://git.openjdk.org/jdk/pull/9957