RFR: 8294211: Zero: Decode arch-specific error context if possible [v2]

[Thomas Stuefe]

On Thu, 22 Sep 2022 18:57:25 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> > Good! But why make this conditional with a switch? Who would not want to have better error information?
> 
> Because I want to be able to test the generic error handling paths that would run on "generic" arch, without leaving the comfort of my x86_64 machine :)

:-) Okay. Like zero-in-zero.

>> src/hotspot/os_cpu/linux_zero/os_linux_zero.cpp line 404:
>> 
>>> 402:   // this at the end, and hope for the best.
>>> 403:   address pc = os::Posix::ucontext_get_pc(uc);
>>> 404:   print_instructions(st, pc, sizeof(char));
>> 
>> Does print_instructions not use safefetch like os::print_hex_dump does? If yes, remove comment? If no, should it?
>
> It does use safe fetch after some change in the past. But all other arches also have this comment, so I prefer to be consistent with them. I think this comment is the left-over from the switch to safefetch on this path. That deserves a separate RFR, I think.

Okay

-------------

PR: https://git.openjdk.org/jdk/pull/10397