RFR: 8293618: x86: Wrong code generation in class Assembler

Tobias Hartmann thartmann at openjdk.org
Fri Sep 23 06:48:09 UTC 2022


On Thu, 22 Sep 2022 07:26:03 GMT, Quan Anh Mai <duke at openjdk.org> wrote:

>> src/hotspot/cpu/x86/assembler_x86.cpp line 351:
>> 
>>> 349: }
>>> 350: 
>>> 351: void Assembler::emit_arith_operand_imm32(int op1, Register rm, Address adr, int32_t imm32) {
>> 
>> Why is this needed?
>
> @TobiHartmann Thanks for taking a look, method entry barrier needs a 4-byte immediate so it can be patched. This method is used in `Assembler::cmpl_imm32`

Okay, so code before emitted an 8-bit immediate. Why didn't that cause any issues when patching?

-------------

PR: https://git.openjdk.org/jdk/pull/10240


More information about the hotspot-dev mailing list