RFR: 8293618: x86: Wrong code generation in class Assembler

Fri Sep 23 08:56:31 UTC 2022

On Wed, 14 Sep 2022 02:17:17 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Hi,
>> 
>> This patch fixes some issues in the code generation of x86 assembler:
>> 
>> - `Assembler::testl` misses `prefix(dst)`
>> - `Assembler::addw` misses the 0x66 prefix
>> - `Assembler::emit_operand` needs the length of the instruction from the address operand, this is often forgotten, making this parameter explicit to prevent potential issues
>> - The assembler should not do optimisations that change the actual emitted instructions, these should be moved to `MacroAssembler` instead
>> 
>> AFAICT there is no failure due to these mistakes. Please take a look and give reviews.
>> Thanks you very much.
>
> Testing passed.

@vnkozlov @TobiHartmann Thanks a lot for your reviews.

-------------

PR: https://git.openjdk.org/jdk/pull/10240